Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a circular dependency check on some objects deps #7

Merged
merged 5 commits into from
Jan 9, 2020

Conversation

pl-buiquang
Copy link
Contributor

@pl-buiquang pl-buiquang commented Dec 19, 2019

Signed-off-by: Paul Bui-Quang [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [x ] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#104

@pl-buiquang pl-buiquang requested a review from geofjamg December 19, 2019 15:21
@pl-buiquang pl-buiquang force-pushed the pbq/add_circular_dependency_check branch from c99d1b4 to 99e35c9 Compare January 6, 2020 08:49
Signed-off-by: Paul Bui-Quang <[email protected]>
@pl-buiquang pl-buiquang force-pushed the pbq/add_circular_dependency_check branch from a9b28dd to 28934b2 Compare January 7, 2020 13:28
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

90.3% 90.3% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit b09d2f7 into master Jan 9, 2020
@geofjamg geofjamg deleted the pbq/add_circular_dependency_check branch January 9, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants